Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageSpeed Insights - Ensure text remains visible during webfont load #834

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

kanhaiya5590
Copy link

Description (*)

Task

https://pagespeed.web.dev/ - PageSpeed Insights

Performance improvement - after changes result => All text remains visible during Webfont loads

Before changes - Ensure text remains visible during Webfont load
image

After changes - All text remains visible during Webfont loads

image

 Fixed and result changes - All text remains visible during Webfont loads
@kanhaiya5590
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@kanhaiya5590
Copy link
Author

Static Tests failed in a different place in the code - anyone can help on this as changes have not impacted that.

@paras89
Copy link
Contributor

paras89 commented Jan 9, 2023

HI @kanhaiya5590, as part of the process, need to fix the static test failures in the file that was edited.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

We are picking this PR for further development

@engcom-Hotel
Copy link
Collaborator

@magento run Static Tests

@engcom-Hotel
Copy link
Collaborator

@magento run Static Tests

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B, Functional Tests EE

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests EE

@engcom-Hotel engcom-Hotel added the Project: Community Picked PRs upvoted by the community label May 22, 2024
@engcom-Hotel engcom-Hotel moved this from Changes Requested to Review in Progress in Pull Request Progress May 22, 2024
@m2-community-project m2-community-project bot added this to Review in Progress in Community Dashboard May 22, 2024
@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Request Progress May 22, 2024
@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard May 22, 2024
@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Hotel
Copy link
Collaborator

The Failed tests seem flaky to me. Hence moving this PR in testing

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Hotel engcom-Hotel moved this from Changes Requested to Ready for Testing in Community Dashboard May 23, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard May 27, 2024
@engcom-Bravo
Copy link
Collaborator

Hi @kanhaiya5590,

Thanks for the collaboration & contribution!.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshot.

Screenshot 2024-05-27 at 12 29 32

Could you please try to reproduce the issue in Latest 2.4-develop instance and could you please let us know if we are still missing anything.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Community Dashboard
Testing in Progress
Development

Successfully merging this pull request may close these issues.

None yet

6 participants