-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Remove increase/decrease buttons of quantity selector from the tab index #3766
Comments
Hi @luke-denton-aligent. Thank you for your report. Add a comment to assign the issue:
|
@Jordaneisenburger Can you please review |
@magento export issue to JIRA project PWA as Story |
✅ Jira issue https://jira.corp.magento.com/browse/PWA-2780 is successfully created for this GitHub issue. |
Thanks for your feedback! We are planning to include accessibility improvements to the quantity stepper in an upcoming feature epic that is currently |
@magento I am working on this |
Confirming issue, Followed the instructions to replicate issue as mentioned in description. |
@adobe export issue to JIRA project PWA as Bug |
✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3173 is successfully created for this GitHub issue. |
as per recent review of this ticket, it pressing tab and navigating control on +/- button is good user expereicne in terms of accessibility scope hence we would not recomment to remove this feature. however could you please let us know that why do you required this change in functionality. |
As we have waited for more than 14 days for response hence we are closing this issue. |
Is your feature request related to a problem? Please describe.
Currently when tabbing through a PDP, a user has to tab twice to get passed the quantity selector. If the value in the quantity selector is greater than 1, then the user will have to tab 3 times to get passed it:
First tab press: Decrease button
Second tab press: quantity input
Third tab press: Increase button
Forth Tab press: next element in the DOM
Further, the increase/decrease buttons don't have any focus state currently either, so a user isn't able to visually see that they are focused on those elements (which we don't have to fix, as we're going to remove those buttons from the tab index)
Describe the solution you'd like
Keyboard users already have access to the keyboard, so that can enter the number for the quantity they like, without having to use the increase/decrease buttons. By removing the buttons from the tab order, we can make the usability of the app much better, without sacrificing any accessibility, as the input field is still focusable.
Unfortunately due to the current implementation of the quantity input itself, a user isn't able to use the up/down arrow keys to change the value, which I'll create another issue for.
Removing the buttons from the tab index would be done by simply adding
tabindex="-1"
to them.Describe alternatives you've considered
Additional context
Add any other context or screenshots about the feature request here.
Please let us know what packages this feature is in regards to:
venia-ui
The text was updated successfully, but these errors were encountered: