Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pwa 2780 remove increment decrement tab selection #4054

Conversation

Sahilsks
Copy link
Contributor

@Sahilsks Sahilsks commented Mar 8, 2023

Description

Remove increase/decrease buttons of quantity selector from the tab index

Related Issue

Closes #3766

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Screen.Recording.2023-03-08.at.2.26.20.PM.mov

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 8, 2023

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 918e5ad

@haal9000
Copy link
Contributor

haal9000 commented Jun 7, 2023

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 7, 2023

Successfully started codebuild job for pr-deploy

@haal9000
Copy link
Contributor

haal9000 commented Jun 7, 2023

run pr-deploy

@pwa-test-bot
Copy link

pwa-test-bot bot commented Jun 7, 2023

Successfully started codebuild job for pr-deploy

@glo82145 glo82145 added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 8, 2023
@glo82145
Copy link
Collaborator

As associated ticket with this PR is closed. hence closing this PR.

@glo82145 glo82145 closed this May 29, 2024
@m2-community-project m2-community-project bot removed this from Reviewer Approved in Pull Request Progress May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: EY partners-contribution pkg:venia-ui version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Remove increase/decrease buttons of quantity selector from the tab index
5 participants