Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4021/server side rendering #4072

Closed
wants to merge 14 commits into from

Conversation

papiliond
Copy link
Contributor

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Mar 27, 2023

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unable to build scaffolded project.

yarn build

within a scaffolded project directory failed.
Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.

🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/pagebuilder/lib/ContentTypes/Products/__tests__/products.spec.js
  • packages/peregrine/lib/talons/CartPage/ProductListing/__tests__/useProduct.spec.js
  • packages/peregrine/lib/talons/MagentoRoute/__tests__/useMagentoRoute.spec.js
  • packages/peregrine/lib/talons/CheckoutPage/__tests__/useShippingMethod.spec.js
  • packages/pwa-buildpack/lib/Utilities/__tests__/serve.spec.js
  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/__tests__/productFullDetail.spec.js
  • packages/peregrine/lib/targets/__tests__/peregrine-targets.spec.js
  • packages/peregrine/lib/talons/Gallery/__tests__/useAddToCartButton.spec.js
  • packages/venia-ui/lib/components/App/__tests__/app.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableSet.spec.js
  • packages/peregrine/lib/talons/AddressBookPage/__tests__/useAddressBookPage.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/__tests__/checkoutPage.spec.js
  • packages/peregrine/lib/talons/RootComponents/Product/__tests__/useProduct.spec.js
  • packages/pagebuilder/lib/ContentTypes/Map/__tests__/map.spec.js
  • packages/venia-ui/lib/components/SearchPage/__tests__/searchPage.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/orderRow.spec.js
  • packages/peregrine/lib/talons/CartPage/GiftCards/__tests__/useGiftCards.spec.js
  • packages/peregrine/lib/talons/Link/__tests__/useLink.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/GiftOptions/__tests__/giftOptions.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/orderDetails.spec.js
  • packages/venia-ui/lib/components/FilterSidebar/__tests__/filterSidebar.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableReactComponent.spec.js
  • packages/venia-ui/lib/components/FilterModal/__tests__/filterModal.spec.js
  • packages/peregrine/lib/Router/__tests__/resolveUnknownRoute.test.js
  • packages/peregrine/lib/talons/Navigation/__tests__/useNavigation.spec.js
  • packages/peregrine/lib/talons/QuantityStepper/__tests__/useQuantityStepper.spec.js
  • packages/venia-ui/lib/components/ProductImageCarousel/__tests__/carousel.spec.js
  • packages/pagebuilder/lib/ContentTypes/Row/__tests__/row.spec.js
  • packages/peregrine/lib/talons/FilterSidebar/__tests__/useFilterSidebar.spec.js
  • packages/peregrine/lib/talons/FilterModal/__tests__/useFilterModal.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/editableForm.spec.js
  • packages/venia-ui/lib/RootComponents/Category/__tests__/categoryContent.spec.js
  • packages/peregrine/lib/talons/SignInPage/__tests__/useSignInPage.spec.js
  • packages/peregrine/lib/context/__tests__/cart.spec.js
  • packages/venia-ui/lib/components/CmsDynamicBlock/__tests__/cmsDynamicBlock.ee.spec.js
  • packages/peregrine/lib/talons/CartPage/__tests__/useCartPage.spec.js
  • packages/peregrine/lib/hooks/__tests__/usePagination.spec.js
  • packages/venia-ui/lib/targets/__tests__/venia-ui-targets.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/__tests__/splice-source-loader.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/paymentsForm.spec.js
  • packages/peregrine/lib/hooks/__tests__/useMediaQuery.spec.js
  • packages/venia-ui/lib/components/SignIn/__tests__/signIn.spec.js
  • packages/peregrine/lib/talons/RootComponents/Category/__tests__/useCategoryContent.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/__tests__/attributeType.spec.js
  • packages/peregrine/lib/talons/Breadcrumbs/__tests__/useBreadcrumbs.spec.js
  • packages/peregrine/lib/talons/App/__tests__/useApp.spec.js
  • packages/venia-ui/lib/components/Newsletter/__tests__/newsletter.spec.js
  • packages/peregrine/lib/talons/CartPage/PriceAdjustments/ShippingMethods/__tests__/useShippingRadios.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/priceSummary.spec.js
  • packages/peregrine/lib/talons/CartPage/PriceAdjustments/__tests__/useCouponCode.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/__tests__/product.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/guestForm.spec.js
  • packages/pwa-buildpack/lib/Utilities/__tests__/createDotEnvFile.spec.js
  • packages/pagebuilder/lib/ContentTypes/ButtonItem/__tests__/buttonItem.spec.js
  • packages/peregrine/lib/talons/CreateAccountPage/__tests__/useCreateAccountPage.spec.js
  • packages/venia-ui/lib/components/ContactPage/__tests__/contactPage.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/__tests__/wrap-esm-loader.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/orderHistoryPage.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/miniCart.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/__tests__/couponCode.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/SingleImportStatement.spec.js
  • packages/venia-ui/lib/components/CategoryList/__tests__/categoryList.spec.js
  • packages/peregrine/lib/talons/OrderHistoryPage/__tests__/useOrderHistoryPage.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingForm.spec.js
  • packages/peregrine/lib/talons/Adapter/__tests__/useAdapter.spec.js
  • packages/peregrine/lib/talons/Image/__tests__/useImage.spec.js
  • packages/venia-ui/lib/components/CartPage/__tests__/cartPage.spec.js
  • packages/venia-ui/lib/components/FilterModal/FilterList/__tests__/filterItem.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/__tests__/paymentInformation.spec.js
  • packages/peregrine/lib/talons/CartPage/ProductListing/__tests__/useProductListing.spec.js
  • packages/pagebuilder/lib/ContentTypes/Column/__tests__/column.spec.js
  • packages/peregrine/lib/talons/ContactPage/__tests__/useContactPage.spec.js
  • packages/pagebuilder/lib/ContentTypes/Image/__tests__/image.shimmer.spec.js
  • packages/pagebuilder/lib/__tests__/factory.spec.js
  • packages/peregrine/lib/talons/ForgotPassword/__tests__/useForgotPassword.spec.js
  • packages/venia-ui/lib/components/Header/__tests__/header.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/shippingMethod.spec.js
  • packages/peregrine/lib/talons/ForgotPasswordPage/__tests__/useForgotPasswordPage.spec.js
  • packages/venia-ui/lib/components/MegaMenu/__tests__/MegaMenuItem.spec.js
  • packages/peregrine/lib/talons/CartPage/PriceSummary/__tests__/useDiscountSummary.spec.js
  • packages/pagebuilder/lib/ContentTypes/Tabs/__tests__/tabs.spec.js
  • packages/peregrine/lib/talons/SavedPaymentsPage/__tests__/useCreditCard.spec.js
  • packages/peregrine/lib/talons/Image/__tests__/useResourceImage.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressBookPage.spec.js
  • packages/venia-ui/lib/components/AccountChip/__tests__/accountChip.spec.js
  • packages/peregrine/lib/talons/MegaMenu/__tests__/useMegaMenuItem.spec.js
  • packages/venia-ui/lib/components/FilterModal/FilterList/__tests__/filterItemRadio.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/customerForm.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/BabelModifyJSXPlugin/__tests__/Operation.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistItem.spec.js
  • packages/venia-ui/lib/components/Dialog/__tests__/dialog.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/items.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/collapsedImageGallery.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlist.spec.js
  • packages/venia-ui/lib/components/AccountMenu/__tests__/accountMenu.spec.js
  • packages/venia-ui/lib/components/MiniCart/ProductList/__tests__/item.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/discountSummary.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ItemsReview/__tests__/itemsReview.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCards.spec.js
  • packages/venia-ui/lib/components/Header/__tests__/cartTrigger.spec.js
  • packages/peregrine/lib/talons/SavedPaymentsPage/__tests__/useSavedPaymentsPage.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ee.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/AddressBook/__tests__/addressBook.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/EditModal/__tests__/productDetail.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addEditDialog.spec.js
  • packages/venia-ui/lib/components/StoreCodeRoute/__tests__/storeCodeRoute.spec.js
  • packages/peregrine/lib/talons/Newsletter/__tests__/useNewsletter.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/braintreeDropin.spec.js
  • packages/babel-preset-peregrine/lib/__tests__/index.spec.js
  • packages/venia-ui/lib/components/CommunicationsPage/__tests__/communicationsPage.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/overview.spec.js
  • packages/venia-ui/lib/components/Breadcrumbs/__tests__/breadcrumbs.spec.js
  • packages/peregrine/lib/talons/Header/__tests__/useCurrencySwitcher.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/addressForm.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/EditModal/__tests__/productForm.spec.js
  • packages/venia-ui/lib/components/Adapter/__tests__/adapter.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingMethods.spec.js
  • packages/venia-ui/lib/components/ProductOptions/__tests__/option.spec.js
  • packages/pagebuilder/lib/ContentTypes/Block/__tests__/block.spec.js
  • packages/peregrine/lib/talons/CartPage/PriceSummary/__tests__/usePriceSummary.spec.js
  • packages/peregrine/lib/talons/CheckoutPage/GuestSignIn/__tests__/useGuestSignIn.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/searchBar.spec.js
  • packages/venia-ui/lib/components/MegaMenu/__tests__/MegaMenu.spec.js
  • packages/venia-ui/lib/components/Navigation/__tests__/navigation.spec.js
  • packages/peregrine/lib/talons/WishlistPage/__tests__/useWishlistPage.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/form.spec.js
  • packages/peregrine/lib/context/__tests__/checkout.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/suggestions.spec.js
  • packages/peregrine/lib/context/__tests__/catalog.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistPage.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ce.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/gallery.spec.js
  • packages/peregrine/lib/context/__tests__/app.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/updateModal.spec.js
  • packages/peregrine/lib/Router/__tests__/Router.test.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/Multiselect/__tests__/multiSelect.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/__tests__/createAccount.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/shippingform.spec.js
  • packages/venia-ui/lib/components/Navigation/__tests__/navHeader.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/Select/__tests__/select.spec.js
  • packages/peregrine/lib/talons/FilterModal/__tests__/useFilterBlock.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/EditModal/__tests__/editModal.spec.js
  • packages/venia-ui/lib/components/Checkbox/__tests__/checkbox.spec.js
  • packages/venia-ui/lib/components/CreateAccount/__tests__/createAccount.spec.js
  • packages/venia-concept/src/__tests__/index.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/giftCardSummary.ee.spec.js
  • packages/pagebuilder/lib/ContentTypes/Image/__tests__/image.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/__tests__/orderConfirmationPage.spec.js
  • packages/peregrine/lib/talons/Header/__tests__/useCartTrigger.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/item.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressCard.spec.js
  • packages/peregrine/lib/talons/CategoryList/__tests__/useCategoryList.spec.js
  • packages/peregrine/lib/hooks/__tests__/useIsInViewport.spec.js
  • packages/venia-ui/lib/components/FilterModal/FilterList/__tests__/filterList.spec.js
  • packages/peregrine/lib/talons/Image/__tests__/usePlaceholderImage.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/searchField.spec.js
  • packages/venia-ui/lib/components/AccountMenu/__tests__/accountMenuItems.spec.js
  • packages/peregrine/lib/context/__tests__/unhandledErrors.spec.js
  • packages/peregrine/lib/talons/ProductFullDetail/CustomAttributes/AttributeType/__tests__/useAttributeType.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/__tests__/shippingInformation.spec.js
  • packages/pagebuilder/lib/ContentTypes/DynamicBlock/__tests__/dynamicBlock.ee.spec.js
  • packages/venia-ui/lib/components/MagentoRoute/__tests__/magentoRoute.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/__tests__/customAttributes.spec.js
  • packages/venia-ui/lib/components/ForgotPassword/__tests__/forgotPassword.spec.js
  • packages/peregrine/lib/talons/FilterModal/__tests__/useFilterList.spec.js
  • packages/pagebuilder/lib/ContentTypes/Video/__tests__/video.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/GuestSignIn/__tests__/guestSignIn.spec.js
  • packages/venia-ui/lib/components/AuthModal/__tests__/authModal.spec.js
  • packages/peregrine/lib/talons/RootComponents/Category/__tests__/useNoProductsFound.spec.js
  • packages/pagebuilder/lib/ContentTypes/Text/__tests__/text.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/__tests__/productListing.spec.js
  • packages/venia-ui/lib/components/FilterModal/FilterList/__tests__/filterDefault.spec.js
  • packages/venia-ui/lib/components/ProductImageCarousel/__tests__/thumbnail.spec.js
  • packages/venia-ui/lib/components/SavedPaymentsPage/__tests__/savedPaymentsPage.spec.js
  • packages/venia-ui/lib/components/Price/__tests__/price.spec.js
  • packages/pagebuilder/lib/ContentTypes/Buttons/__tests__/buttons.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/taxSummary.spec.js
  • packages/pagebuilder/lib/ContentTypes/Html/__tests__/html.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/Textarea/__tests__/textarea.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/Text/__tests__/text.spec.js
  • packages/venia-ui/lib/components/AddToCartDialog/__tests__/addToCartDialog.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/autocomplete.spec.js
  • packages/peregrine/lib/talons/Header/__tests__/useHeader.spec.js
  • packages/venia-ui/lib/components/Password/__tests__/password.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/gallery.shimmer.spec.js
  • packages/venia-ui/lib/components/FilterModal/__tests__/filterBlock.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/shippingSummary.spec.js
  • packages/venia-ui/lib/components/SavedPaymentsPage/__tests__/creditCard.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/giftOptionsSummary.ee.spec.js
  • packages/pagebuilder/lib/ContentTypes/Products/Carousel/__tests__/carousel.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/actionMenu.ee.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistEditFavoritesListDialog.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/accountInformationPage.spec.js
  • packages/peregrine/lib/store/reducers/__tests__/app.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/AddressBook/__tests__/addressCard.spec.js
  • packages/venia-ui/lib/components/MegaMenu/__tests__/Submenu.spec.js
  • packages/venia-ui/lib/components/FilterModal/CurrentFilters/__tests__/currentFilter.spec.js
  • packages/venia-ui/lib/components/Shimmer/__tests__/shimmer.spec.js
  • packages/pagebuilder/lib/ContentTypes/TabItem/__tests__/tabItem.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/product.spec.js
  • packages/pagebuilder/lib/ContentTypes/Slider/__tests__/slider.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/__tests__/giftOptionsSection.ee.spec.js
  • packages/peregrine/lib/talons/CategoryList/__tests__/useCategoryTile.spec.js
  • packages/venia-ui/lib/components/App/__tests__/localeProvider.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingRadios.spec.js
  • packages/venia-ui/lib/components/ProductSort/__tests__/sortItem.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/BabelModifyJSXPlugin/__tests__/JSXSnippetParser.spec.js
  • packages/venia-ui/lib/components/FilterModalOpenButton/__tests__/filterModalOpenButton.shimmer.spec.js
  • packages/venia-ui/lib/components/ProductSort/__tests__/productSort.shimmer.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/createWishlist.ee.spec.js
  • packages/venia-ui/lib/components/Routes/__tests__/authRoute.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistConfirmRemoveProductDialog.spec.js
  • packages/peregrine/lib/talons/ContactPage/__tests__/useContactLink.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCard.spec.js
  • packages/peregrine/lib/talons/MegaMenu/__tests__/useSubMenu.spec.js
  • packages/peregrine/lib/talons/AccountChip/__tests__/useAccountChip.spec.js
  • packages/venia-ui/lib/components/Region/__tests__/region.spec.js
  • packages/venia-ui/lib/components/ContactPage/__tests__/contactLink.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/item.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/suggestedCategories.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableESModuleObject.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableESModuleArray.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/suggestedProducts.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/shippingRadios.spec.js
  • packages/venia-ui/lib/components/FilterModal/__tests__/filterFooter.spec.js
  • packages/extensions/venia-sample-payments-checkmo/src/components/__tests__/checkmo.spec.js
  • packages/venia-ui/lib/components/Pagination/__tests__/pagination.spec.js
  • packages/venia-ui/lib/components/MegaMenu/__tests__/SubmenuColumn.spec.js
  • packages/venia-ui/lib/components/CategoryTree/__tests__/categoryLeaf.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/addToCartButton.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/DateTime/__tests__/dateTime.spec.js
  • packages/pagebuilder/lib/__tests__/config.spec.js
  • packages/venia-ui/lib/components/RadioGroup/__tests__/radioGroup.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/orderTotal.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/Boolean/__tests__/boolean.spec.js
  • packages/venia-ui/lib/components/FilterModal/CurrentFilters/__tests__/currentFilters.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/Price/__tests__/price.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/CustomAttributes/AttributeType/Date/__tests__/date.spec.js
  • packages/venia-ui/lib/components/CategoryTree/__tests__/categoryTree.spec.js
  • packages/venia-ui/lib/components/Header/__tests__/accountTrigger.spec.js
  • packages/pagebuilder/lib/ContentTypes/Heading/__tests__/heading.spec.js
  • packages/venia-ui/lib/components/Country/__tests__/country.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/productList.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/__tests__/editModal.spec.js
  • packages/venia-ui/lib/components/ForgotPassword/ForgotPasswordForm/__tests__/forgotPasswordForm.spec.js
  • packages/venia-ui/lib/components/Footer/__tests__/footer.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/shippingMethod.spec.js
  • packages/venia-ui/lib/components/Main/__tests__/main.spec.js
  • packages/venia-ui/lib/components/SearchBar/__tests__/suggestedProduct.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/completedView.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editModal.spec.js
  • packages/peregrine/lib/talons/CartPage/GiftCards/__tests__/useGiftCard.spec.js
  • packages/peregrine/lib/talons/MyAccount/__tests__/useMyAccount.spec.js
  • packages/pagebuilder/lib/ContentTypes/Divider/__tests__/divider.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistItems.spec.js
  • packages/venia-ui/lib/components/Accordion/__tests__/accordion.spec.js
  • packages/venia-ui/lib/components/CategoryTree/__tests__/categoryBranch.spec.js
  • packages/venia-ui/lib/components/FilterModalOpenButton/__tests__/filterModalOpenButton.spec.js
  • packages/venia-ui/lib/components/ProductOptions/__tests__/options.spec.js
  • packages/peregrine/lib/hooks/__tests__/useIntersectionObserver.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/body.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/__tests__/quantity.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editForm.spec.js
  • packages/venia-ui/lib/components/CurrencySymbol/__tests__/currencySymbol.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/PriceAdjustments/__tests__/priceAdjustments.spec.js
  • packages/venia-ui/lib/components/App/__tests__/contextProvider.spec.js
  • packages/peregrine/lib/util/__tests__/imageUtils.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/addressForm.spec.js
  • packages/venia-ui/lib/components/App/__tests__/container.spec.js
  • packages/peregrine/lib/hooks/__tests__/useScrollIntoView.spec.js
  • packages/venia-ui/lib/components/Routes/__tests__/routes.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/resetButton.spec.js
  • packages/venia-ui/lib/components/ButtonGroup/__tests__/buttonGroup.spec.js
  • packages/venia-ui/lib/components/StockStatusMessage/__tests__/stockStatusMessage.spec.js
  • packages/peregrine/lib/talons/Accordion/__tests__/useAccordion.spec.js
  • packages/venia-ui/lib/components/ForgotPasswordPage/__tests__/forgotPasswordPage.spec.js
  • packages/venia-ui/lib/components/CreateAccountPage/__tests__/createAccountPage.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/__tests__/giftCardSection.ee.spec.js
  • packages/venia-ui/lib/components/SortedByContainer/__tests__/sortedByContainer.shimmer.spec.js
  • packages/venia-ui/lib/components/FormError/__tests__/formError.spec.js
  • packages/venia-ui/lib/components/RichContent/__tests__/richContent.spec.js
  • packages/venia-ui/lib/components/MiniCart/ProductList/__tests__/productList.spec.js
  • packages/venia-ui/lib/components/AriaButton/__tests__/ariaButton.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistMoreActionsDialog.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/shippingInformation.spec.js
  • packages/extensions/venia-sample-payments-checkmo/src/components/__tests__/summary.spec.js
  • packages/venia-ui/lib/components/ForgotPassword/FormSubmissionSuccessful/__tests__/formSubmissionSuccessful.spec.js
  • packages/extensions/venia-sample-payments-checkmo/src/components/__tests__/edit.spec.js
  • packages/venia-ui/lib/components/Checkout/Receipt/__tests__/receipt.spec.js
  • packages/venia-ui/lib/components/SignInPage/__tests__/signInPage.spec.js
  • packages/venia-ui/lib/components/WishlistPage/__tests__/wishlistListActionsDialog.spec.js
  • packages/venia-ui/lib/components/ScrollAnchor/__tests__/scrollAnchor.spec.js
  • packages/venia-ui/lib/components/CmsDynamicBlock/__tests__/dynamicBlock.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/billingInformation.spec.js
  • packages/peregrine/lib/talons/AccountMenu/__tests__/useAccountMenuItems.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/orderProgressBar.spec.js
  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.shimmer.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/__tests__/card.spec.js
  • packages/peregrine/lib/hooks/__tests__/useResetForm.spec.js
  • packages/pagebuilder/lib/ContentTypes/DynamicBlock/__tests__/dynamicBlock.shimmer.spec.js
  • packages/pagebuilder/lib/ContentTypes/Slider/__tests__/slider.shimmer.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/__tests__/errorMessage.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/__tests__/priceAdjustments.spec.js
  • packages/pagebuilder/lib/ContentTypes/ColumnGroup/__tests__/columnGroup.spec.js
  • packages/venia-ui/lib/components/SavedPaymentsPage/__tests__/paymentCard.spec.js
  • packages/pagebuilder/lib/ContentTypes/ColumnLine/__tests__/columnLine.spec.js
  • packages/venia-ui/lib/components/ContactPage/__tests__/contactPage.shimmer.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/kebab.spec.js
  • packages/venia-ui/lib/components/App/__tests__/useErrorBoundary.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/OrderSummary/__tests__/orderSummary.spec.js
  • packages/venia-ui/lib/components/ErrorMessage/__tests__/errorMessage.spec.js
  • packages/venia-ui/lib/components/ProductSort/__tests__/productSort.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/giftOptionsSummary.ce.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/__tests__/giftOptionsSection.ce.spec.js
  • packages/venia-ui/lib/components/CmsDynamicBlock/__tests__/cmsDynamicBlock.ce.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/giftCardSummary.ce.spec.js
  • packages/pagebuilder/lib/ContentTypes/DynamicBlock/__tests__/dynamicBlock.ce.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/__tests__/giftCardSection.ce.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/footer.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/paymentMethod.spec.js
  • packages/venia-ui/lib/components/CmsBlock/__tests__/block.spec.js
  • packages/venia-ui/lib/RootComponents/Category/__tests__/categoryContent.shimmer.spec.js
  • packages/venia-ui/lib/components/Newsletter/__tests__/newsletter.shimmer.spec.js
🚫

The following file(s) did not pass ESLint. Execute yarn run lint locally for more details

packages/babel-preset-peregrine/package.json
packages/pwa-buildpack/lib/Utilities/serve.js
packages/ssr/.eslintrc.js
packages/ssr/lib/Utilities/InMemoryCache/esm/cache.js
packages/ssr/lib/utils/html.js
packages/ssr/package.json
packages/venia-ui/lib/components/AccountInformationPage/accountInformationPage.js
packages/venia-ui/lib/components/CartPage/PriceAdjustments/giftCardSection.ee.js
packages/venia-ui/lib/components/Main/main.js
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing information in PR. Please fill out the "Description" section.
Warnings
⚠️ Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: eslintCheck


ERROR ON TASK: unitTests


ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against 4757c47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants