Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3172: [bug]: Regions select stuck in loading state in checkout when US is disabled #4156

Closed
wants to merge 3 commits into from

Conversation

Tarun50745
Copy link
Contributor

@Tarun50745 Tarun50745 commented Aug 17, 2023

Description

When United States is not selected in the backend General > Country Options > Allow Countries configuration, the checkout fails to load the "States" field in the checkout. This is because it passes US to the GetRegions by default but this returns a graphql error when US is not active. When there is only one country available this causes the checkout to fully break as there's no way to trigger the load of the states.

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3172.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Aug 17, 2023

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3172.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 7c6b46e

@Tarun50745 Tarun50745 added the version: Minor This changeset includes functionality added in a backwards compatible manner. label Aug 28, 2023
@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Aug 29, 2023
@glo82145 glo82145 closed this May 29, 2024
@m2-community-project m2-community-project bot removed this from Reviewer Approved in Pull Request Progress May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:pwa-buildpack version: Minor This changeset includes functionality added in a backwards compatible manner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants