Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3162::price filter incorrectly fetches/displays #4162

Closed
wants to merge 4 commits into from

Conversation

glo80771
Copy link
Contributor

Description

In the event that a different price filter is applied after a price filter is already applied, the query will only be for the first price filter, not the combination of the two.

This behavior might be interpreted as a bug but is actually a mis-implementation of the UI for the price filter which only allows a "range" ie {{

{ "from": "0", "to": "100" }
}}.

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3162.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 14, 2023

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/__tests__/productFullDetail.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/__tests__/checkoutPage.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/orderDetails.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableReactComponent.spec.js
  • packages/venia-ui/lib/components/ProductImageCarousel/__tests__/carousel.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/paymentsForm.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/priceSummary.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/__tests__/product.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/guestForm.spec.js
  • packages/pagebuilder/lib/ContentTypes/ButtonItem/__tests__/buttonItem.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/orderHistoryPage.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/__tests__/couponCode.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingForm.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/shippingMethod.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressBookPage.spec.js
  • packages/venia-ui/lib/components/Dialog/__tests__/dialog.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/customerForm.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ee.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCards.spec.js
  • packages/venia-ui/lib/components/MyAccount/ResetPassword/__tests__/resetPassword.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/AddressBook/__tests__/addressBook.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/__tests__/braintreeSummary.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/overview.spec.js
  • packages/venia-ui/lib/components/CommunicationsPage/__tests__/communicationsPage.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/addressForm.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingMethods.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/EditModal/__tests__/productForm.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ce.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/updateModal.spec.js
  • packages/venia-ui/lib/RootComponents/Category/__tests__/category.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/__tests__/createAccount.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/shippingform.spec.js
  • packages/venia-ui/lib/components/CreateAccount/__tests__/createAccount.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressCard.spec.js
  • packages/venia-ui/lib/components/Wishlist/WishlistDialog/CreateWishlistForm/__tests__/createWishlistForm.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/__tests__/shippingInformation.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/GuestSignIn/__tests__/guestSignIn.spec.js
  • packages/venia-ui/lib/components/MiniCart/__tests__/miniCart.spec.js
  • packages/venia-ui/lib/components/AddToCartDialog/__tests__/addToCartDialog.spec.js
  • packages/venia-ui/lib/components/Password/__tests__/password.spec.js
  • packages/venia-ui/lib/components/SavedPaymentsPage/__tests__/creditCard.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCard.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/item.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/addToCartButton.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/section.spec.js
  • packages/venia-ui/lib/components/ForgotPassword/ForgotPasswordForm/__tests__/forgotPasswordForm.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/completedView.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editModal.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editForm.spec.js
  • packages/venia-ui/lib/components/Checkout/Receipt/__tests__/receipt.spec.js
  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.shimmer.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/checkoutButton.spec.js
  • packages/venia-ui/lib/components/ProductSort/__tests__/productSort.spec.js
Messages
📖

Associated JIRA tickets: PWA-3162.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 52a3724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants