Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA-3260 :Unable to execute javascript tags which added in block in P… #4264

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

glo85315
Copy link
Collaborator

@glo85315 glo85315 commented May 8, 2024

Description

Login to Magento Admin
Create or Edit block, add html element and add any javascript in that
Add that block in footer or somewhere in page
Goto PWA Venia frontend and check, javascript is loading but it is not executable.

Related Issue

Closes #https://jira.corp.adobe.com/browse/PWA-3260

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Login to Magento Admin
Create or Edit block, add html element and add any javascript in that
Add that block in footer or somewhere in page
Goto PWA Venia frontend and check, javascript is loading .

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo85315 glo85315 added pkg:peregrine version: Patch This changeset includes backwards compatible bug fixes. labels May 8, 2024
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress May 8, 2024
@glo85315 glo85315 requested a review from glo82145 May 8, 2024 05:57
@glo85315 glo85315 added needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA needs triage and removed needs-triage A pull request or issue that needs to be triaged prior to being synced to JIRA labels May 8, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented May 8, 2024

Fails
🚫

node failed.

🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/hooks/useCustomerWishlistSkus/__tests__/useCustomerWishlistSkus.spec.js
Messages
📖

Associated JIRA tickets: PWA-3260.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 3027788

glo82145
glo82145 previously approved these changes May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: approved version: Patch This changeset includes backwards compatible bug fixes.
Projects
Pull Request Progress
Reviewer Approved
Development

Successfully merging this pull request may close these issues.

None yet

3 participants