Place the PHP version into a variable (#2307) #2308
Conversation
binarykitchen
force-pushed
the
feature/2307
branch
4 times, most recently
from
b3087af
to
7d23073
Compare
CHANGELOG.md
Outdated
| @@ -1,6 +1,11 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| Next | |||
There was a problem hiding this comment.
Helping you ahead to write the next changelog :)
tools/mail.py
Outdated
There was a problem hiding this comment.
Nowhere else used.
|
Tested it with the local Vagrant file. Zero errors. |
| @@ -8,15 +8,15 @@ | |||
|
|
|||
| source /etc/mailinabox.conf # load global vars | |||
|
|
|||
| ADMIN=$(./mail.py user admins | head -n 1) | |||
There was a problem hiding this comment.
That was actually just redirecting to management/cli.py, hence fixing the path.
But that file, mail.py, is still here, for backward compatibility.
|
I've tested everything all over again:
|
|
I think it looks ok 👍 . Just reviewed it, did not test it. Next time, I would keep out the cleanup stuff, it just makes for noise... |
|
@kiekerjan Do you want me to move the clean-up stuff in a separate commit and trim all the trailing whitespaces everywhere in one single commit? |
|
No, don't bother 😉 Something to keep in mind for next time. This pull request is not so large, so it's not so bad, but if you have a large pull request, it is distracting to have these changes in there as well. |
binarykitchen
force-pushed
the
feature/2307
branch
from
7d23073
to
2477d09
Compare
Also - trims a few trailing whitespace characters - gitignores VS code workspace
binarykitchen
force-pushed
the
feature/2307
branch
from
2477d09
to
2a0cd8b
Compare
Also