Add transport response callback #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoubleDi
reviewed
Feb 2, 2024
| type ctxKey uint8 | ||
|
|
||
| const ( | ||
| ctxRespCallbackKey ctxKey = iota + 1 |
There was a problem hiding this comment.
Please use an empty struct, as a more connonical way
| @@ -287,6 +287,12 @@ func (c *conn) doRequest(ctx context.Context, req *http.Request) (io.ReadCloser, | |||
| // response | |||
| return nil, newError(string(msg)) | |||
| } | |||
|
|
|||
| if err = callCtxRespCallback(ctx, req, resp); err != nil { | |||
There was a problem hiding this comment.
Could we move this callback higher so non 200 calls also get invoced?
There was a problem hiding this comment.
an error in callback should not fail the response to the database.
|
Thanks for your contribution! Added small comments. Nothing Major |
DoubleDi
reviewed
Feb 2, 2024
| ctxRespCallbackKey ctxKey = iota + 1 | ||
| ) | ||
|
|
||
| // RespCallback is a transport response callback. |
There was a problem hiding this comment.
Could you add a comment when it is invoked and in what cases
DoubleDi
reviewed
Feb 2, 2024
| ) | ||
|
|
||
| // RespCallback is a transport response callback. | ||
| type RespCallback func(*http.Request, *http.Response) error |
There was a problem hiding this comment.
RespCallback is short for a response callback, nothing stated about the request. Maybe we should call it TransportCallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to handle transport response