Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a popup authenticator #2367

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement a popup authenticator #2367

wants to merge 1 commit into from

Conversation

pichfl
Copy link
Contributor

@pichfl pichfl commented Apr 1, 2022 •
edited

This aims to be the foundation for replacing the deprecated and abandoned torii ember addon and the authenticator we deprecated that relied on it.

Scope of this PR / authenticator:

  • Provide a base implementation
  • Open a third party (oAuth1/2) login page in a managed popup
  • Handle the authentication redirect and closing of the popup
  • Make it easy to extend the authenticator to your needs (e.g. by adopting certain torii providers)

Not part of the scope of this PR / authenticator:

  • Include and replicate all providers included by torii

Todo

  • Figure out if this is a sensible way forward
  • Write tests
  • Provide documentation
  • Provide migration guide going from torii to this

@pichfl pichfl force-pushed the pichfl/popup-authenticator branch from 04d7bda to f7e9a4f Compare April 29, 2022 10:19
@pichfl pichfl force-pushed the pichfl/popup-authenticator branch from f7e9a4f to 550ecf4 Compare April 29, 2022 10:23
@pichfl pichfl mentioned this pull request Jul 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pichfl