Fix compile_targets.py when using numpy 1.24.0 or newer #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217
Numpy 1.24.0 removed creation of arrays with mismatched dimensions to have implicit
dtype=object
. To maintain the old behavior,dtype=object
has to be specified explicitly.https://numpy.org/neps/nep-0034-infer-dtype-is-object.html
This changes the return type of
LicenseInfo.toNumpyString()
to a numpy array. The method is used in three places:np.save
method. With this change, it gets a numpy array instead of a tuple, so the behavior is exactly the same as with older numpy versions.np.ascontiguousarray
, which also converts arguments implicitly to numpy arrays, so this should work with the change as well.