Resizing #97
Open
Resizing #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsferruzza
reviewed
Nov 30, 2021
src/config/environment.rs
Outdated
| @@ -22,53 +22,61 @@ lazy_static! { | |||
| if *SIMULATOR_ENABLED { 3 } else { 2 }; | |||
| } | |||
|
|
|||
| pub const FACTORF64: f64 = 2.0; | |||
There was a problem hiding this comment.
Maybe we can get this value from an env variable at compile-time (see option_env!), and use 1 as default value?
Something like this? (not tested)
Suggested change
| pub const FACTORF64: f64 = 2.0; | |
| pub const FACTOR: f64 = option_env!("SCALE_FACTOR").and_then(|f| f64::from_str(&f).ok()).unwrap_or(1.0); |
If necessary this can also be the place to validate the value (and if not valid we take the default one).
There was a problem hiding this comment.
Unfortunately, const types doesnt support non const operation.
| ); | ||
| let src = (image).as_rgba(); | ||
|
|
||
| let mut dst = vec![RGBA::new(0, 0, 0, 0); (w2 * h2).try_into().unwrap()]; |
There was a problem hiding this comment.
Is this part useful?
Suggested change
| let mut dst = vec![RGBA::new(0, 0, 0, 0); (w2 * h2).try_into().unwrap()]; | |
| let mut dst = vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow resizing of the UI.
This PR is still WIP