capricorn86#976@minor: Optimizations.

malko · Jul 17, 2023 · 4054058 · 4054058
1 parent 1052bbb
commit 4054058
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/packages/happy-dom/src/css/declaration/css-parser/CSSStyleDeclarationCSSParser.ts b/packages/happy-dom/src/css/declaration/css-parser/CSSStyleDeclarationCSSParser.ts
@@ -1,3 +1,10 @@
+// PropName   => \s*([^:;]+?)\s*:
+// PropValue  => \s*((?:[^(;]*?(?:\([^)]*\))?)*?) <- will match any non ';' char except inside (), nested parentheses are not supported
+// !important => \s*(!important)?
+// EndOfRule  => \s*(?:$|;)
+const SPLIT_RULES_REGEXP =
+	/\s*([^:;]+?)\s*:\s*((?:[^(;]*?(?:\([^)]*\))?)*?)\s*(!important)?\s*(?:$|;)/g;
+
 /**
  * CSS parser.
  */
@@ -12,19 +19,11 @@ export default class CSSStyleDeclarationCSSParser {
 		cssText: string,
 		callback: (name: string, value: string, important: boolean) => void
 	): void {
-		const rules = [
-			...cssText.matchAll(
-				// PropName   => \s*([^:;]+?)\s*:
-				// PropValue  => \s*((?:[^(;]*?(?:\([^)]*\))?)*?) <- will match any non ';' char except inside (), nested parentheses are not supported
-				// !important => \s*(!important)?
-				// EndOfRule  => \s*(?:$|;)
-				/\s*([^:;]+?)\s*:\s*((?:[^(;]*?(?:\([^)]*\))?)*?)\s*(!important)?\s*(?:$|;)/g
-			)
-		];
-		rules.forEach(([, key, value, important]) => {
+		const rules = Array.from(cssText.matchAll(SPLIT_RULES_REGEXP));
+		for (const [, key, value, important] of rules) {
 			if (key && value) {
 				callback(key.trim(), value.trim(), !!important);
 			}
-		});
+		}
 	}
 }