Fix baseURL in vega extensions jupyterlab#7047

This ensures that the path of the current notebook is included in the URL for data files in the vega extensions.
malramsay64 · Aug 19, 2019 · 0893e7b · 0893e7b
1 parent 3592afd
commit 0893e7b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/vega4-extension/src/index.ts b/packages/vega4-extension/src/index.ts
@@ -92,7 +92,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer {
       this._result.view.finalize();
     }
 
+    const path = await this._resolver.resolveUrl('');
+    const baseURL = await this._resolver.getDownloadUrl(path);
     const loader = vega.vega.loader({
+      baseURL,
       http: { credentials: 'same-origin' }
     });
 

diff --git a/packages/vega5-extension/src/index.ts b/packages/vega5-extension/src/index.ts
@@ -92,7 +92,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer {
       this._result.view.finalize();
     }
 
+    const path = await this._resolver.resolveUrl('');
+    const baseURL = await this._resolver.getDownloadUrl(path);
     const loader = vega.vega.loader({
+      baseURL,
       http: { credentials: 'same-origin' }
     });
     const sanitize = async (uri: string, options: any) => {