[@mantine/dates] DatePicker: Set withinPortal to false by default

mantinedev · Aug 17, 2022 · 7eeb278 · 7eeb278
1 parent ca3b091
commit 7eeb278
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/docs/src/docs/changelog/5-2-0.mdx b/docs/src/docs/changelog/5-2-0.mdx
@@ -47,3 +47,4 @@ function AsteriskDemo() {
 - [Carousel](https://mantine.dev/others/carousel/) component now supports `height="100%"`
 - [Grid.Col](https://mantine.dev/core/grid/) now supports `order` prop, it can be used to reorder columns when certain breakpoint is reached
 - [Tabs](https://mantine.dev/core/tabs/) component now supports `keepMounted` prop. If it is set to `false` then components rendered inside `Tabs.Panel` will be unmounted when tab is not active.
+- [DatePicker and DateRangePicker](https://mantine.dev/dates/date-picker/) components now have `withinPortal` prop set to `false` by default to match other components
diff --git a/src/mantine-dates/src/components/DatePicker/DatePicker.tsx b/src/mantine-dates/src/components/DatePicker/DatePicker.tsx
@@ -60,7 +60,7 @@ const defaultProps: Partial<DatePickerProps> = {
   clearable: true,
   disabled: false,
   fixOnBlur: true,
-  withinPortal: true,
+  withinPortal: false,
   firstDayOfWeek: 'monday',
   openDropdownOnClear: false,
 };

diff --git a/src/mantine-dates/src/components/DatePickerBase/DatePickerBase.tsx b/src/mantine-dates/src/components/DatePickerBase/DatePickerBase.tsx
@@ -172,7 +172,7 @@ export const DatePickerBase = forwardRef<HTMLInputElement, DatePickerBaseProps>(
       onClear,
       positionDependencies = [],
       zIndex,
-      withinPortal = true,
+      withinPortal = false,
       onBlur,
       onFocus,
       onChange,

diff --git a/src/mantine-dates/src/components/DateRangePicker/DateRangePicker.tsx b/src/mantine-dates/src/components/DateRangePicker/DateRangePicker.tsx
@@ -74,7 +74,7 @@ const defaultProps: Partial<DateRangePickerProps> = {
   firstDayOfWeek: 'monday',
   allowSingleDateInRange: false,
   amountOfMonths: 1,
-  withinPortal: true,
+  withinPortal: false,
   openDropdownOnClear: false,
 };