[@mantine/carousel] Carousel: fixed carousel indicator not changing w…

…hen slidesToScroll value is changed (#3058)
mantinedev · Nov 28, 2022 · c0379f4 · c0379f4
1 parent 23ccf51
commit c0379f4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/mantine-carousel/src/Carousel.tsx b/src/mantine-carousel/src/Carousel.tsx
@@ -255,7 +255,7 @@ export const _Carousel = forwardRef<HTMLDivElement, CarouselProps>((props, ref)
     }
 
     return undefined;
-  }, [embla]);
+  }, [embla, slidesToScroll]);
 
   useEffect(() => {
     if (embla) {
@@ -265,7 +265,7 @@ export const _Carousel = forwardRef<HTMLDivElement, CarouselProps>((props, ref)
         clamp(currentSelected, 0, Children.toArray(children).length - 1)
       );
     }
-  }, [Children.toArray(children).length]);
+  }, [Children.toArray(children).length, slidesToScroll]);
 
   const canScrollPrev = embla?.canScrollPrev() || false;
   const canScrollNext = embla?.canScrollNext() || false;