[@mantine/hooks] Fixing use-hash extra rerendering issue
#3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs fixed: * If you `setHash` to something that doesn't start with "#" it would be reflect that temporarily in `hash` * `setHashValue` was being called multiple times (one in the listener and the set hash) resulting in the multiple renders Result: * `setHash` only rerenders the page once.
rtivital
requested changes
Dec 2, 2022
| import { useWindowEvent } from '../use-window-event/use-window-event'; | ||
|
|
||
| export function useHash() { | ||
| const [hash, setHashValue] = useState<string>(''); | ||
| const [hash, setHashValue] = useState<string>(() => window.location.hash); |
There was a problem hiding this comment.
This will fail during ssr, window object does not exist.
|
Please fix failed tests |
|
Please fix failed tests, before pushing run |
|
Thanks! Sorry about that, I'm a little new to this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs fixed:
setHashto something that doesn't start with "#" it would be reflect that temporarily inhashsetHashValuewas being called multiple times (one in the listener and the set hash) resulting in the multiple rendersResult:
setHashonly rerenders the page once.hashconsistently starts with '#'