Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/hooks] Fixing use-hash extra rerendering issue #3097

Merged
merged 4 commits into from Dec 4, 2022
Merged

[@mantine/hooks] Fixing use-hash extra rerendering issue #3097

merged 4 commits into from Dec 4, 2022

Commits on Dec 2, 2022

  1. Fix use-hash extra rerendering issue 

    Two bugs fixed:
* If you `setHash` to something that doesn't start with "#" it would be reflect that temporarily in `hash`
* `setHashValue` was being called multiple times (one in the listener and the set hash) resulting in the multiple renders

Result:
* `setHash` only rerenders the page once.
    @hunterwilhelm
    hunterwilhelm committed Dec 2, 2022
    Copy the full SHA
    046ec0f View commit details
    Browse the repository at this point in the history

  2. Fix tests 

    window is not defined in ssr
    @hunterwilhelm
    hunterwilhelm committed Dec 2, 2022
    Copy the full SHA
    e1d3e5f View commit details
    Browse the repository at this point in the history

  3. fix formatting

    @hunterwilhelm
    hunterwilhelm committed Dec 2, 2022
    Copy the full SHA
    466a9bc View commit details
    Browse the repository at this point in the history

  4. Fix no-param-reassign and prefer-template

    @hunterwilhelm
    hunterwilhelm committed Dec 2, 2022
    Copy the full SHA
    7d7f44c View commit details
    Browse the repository at this point in the history