Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Table: Fix wrong styling with borders and rowspan #3106

Merged

Conversation

seeratawan01
Copy link
Contributor

@seeratawan01 seeratawan01 commented Dec 3, 2022

Issue: #3049

Description

Fixed the style issues with table component. There are multiple issues with borders when we use the table component with different props such as striped, withBorder or withColumnBorders.

What package has changed?

@mantine/core

Fixes # (issues)

[x] When we use withColumnBorders and rowSpan, the border left is not visible of the cells which are now in front of the rowSpan cell. (This is fixed by using borderRight instead of borderLeft for the cells)

[x] When we use rowSpan and rowspaned cell reaches the last row, the unexpected border bottom is added to the last row. (This is fixed by using borderTop for the rows instead of borderBottom)

[ ] When we use striped, striping works well but when the rowspan is used along, the user might expect the striping to be applied to the cells in front of the rowspan cell regarded as one row. (This is not fixed)

Screenshots

normal without any props
image

props: withBorder, withColumnBorders and striped
image

props: withColumnBorders and striped
image

@rtivital rtivital merged commit ffc603f into mantinedev:master Dec 4, 2022
@rtivital
Copy link
Member

rtivital commented Dec 4, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants