[@mantine/core] Table: Fix wrong styling with borders and rowspan #3106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3049
Description
Fixed the style issues with table component. There are multiple issues with borders when we use the table component with different props such as striped, withBorder or withColumnBorders.
What package has changed?
@mantine/core
Fixes # (issues)
[x] When we use withColumnBorders and rowSpan, the border left is not visible of the cells which are now in front of the rowSpan cell. (This is fixed by using borderRight instead of borderLeft for the cells)
[x] When we use rowSpan and rowspaned cell reaches the last row, the unexpected border bottom is added to the last row. (This is fixed by using borderTop for the rows instead of borderBottom)
[ ] When we use striped, striping works well but when the rowspan is used along, the user might expect the striping to be applied to the cells in front of the rowspan cell regarded as one row. (This is not fixed)
Screenshots
normal without any props
props: withBorder, withColumnBorders and striped
props: withColumnBorders and striped