improve types #1885
Merged
improve types #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a named type for `Record<string, ThemeComponent>` - remove unnecessary code (`fn` was being `Omit`ted twice) - refactor to use `Partial<Pick<>`
brunocrosier
commented
Jul 27, 2022
| @@ -98,9 +99,6 @@ interface ThemeComponent { | |||
| } | |||
|
|
|||
| export type MantineThemeBase = Omit<MantineTheme, 'fn'>; | |||
| export type MantineThemeOverride = DeepPartial< | |||
| Omit<MantineThemeBase, 'fn' | 'other' | 'components'> | |||
There was a problem hiding this comment.
we don't need to omit fn as we're already doing that in MantineThemeBase
brunocrosier
commented
Jul 27, 2022
| }; | ||
|
|
||
| export type MantineThemeOverride = DeepPartial<Omit<MantineThemeBase, 'other' | 'components'>> & | ||
| Partial<Pick<MantineThemeBase, 'other' | 'components'>>; |
There was a problem hiding this comment.
better and safer to Pick directly from MantineThemeBase, otherwise the types could fall out of sync
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record<string, ThemeComponent>fnwas beingOmitted twice)Partial<Pick<>