New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@mantine/core] Multiselect: match styles of TextInput #2154
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
846e180
[@mantine/core] Select: only use open/close callback when value changes
wes337 9e8045f
[@mantine/core] Select: do not use early return
wes337 8f446fa
Merge remote-tracking branch 'upstream/master'
wes337 40ea5cd
Merge remote-tracking branch 'upstream/master'
wes337 e1c76d0
Merge remote-tracking branch 'upstream/master'
wes337 52f4349
Merge remote-tracking branch 'upstream/master'
wes337 a74533c
Merge remote-tracking branch 'upstream/master'
wes337 75852b2
Merge remote-tracking branch 'upstream/master'
wes337 bc2b0db
Merge remote-tracking branch 'upstream/master'
wes337 a3c4287
Merge remote-tracking branch 'upstream/master'
wes337 4afe44a
Merge remote-tracking branch 'upstream/master'
wes337 6ac338e
Merge remote-tracking branch 'upstream/master'
wes337 3c04aba
Merge remote-tracking branch 'upstream/master'
wes337 75c8f60
Merge remote-tracking branch 'upstream/master'
wes337 7ce8791
Merge remote-tracking branch 'upstream/master'
wes337 d96a3a6
Merge remote-tracking branch 'upstream/master'
wes337 936dbb3
Merge remote-tracking branch 'upstream/master'
wes337 a53a6e2
Merge remote-tracking branch 'upstream/master'
wes337 b4b3751
Merge remote-tracking branch 'upstream/master'
wes337 1053827
Merge remote-tracking branch 'upstream/master'
wes337 3ad1b2a
Merge remote-tracking branch 'upstream/master'
wes337 8e439e1
Merge remote-tracking branch 'upstream/master'
wes337 f576e77
Merge remote-tracking branch 'upstream/master'
wes337 52a9357
Merge remote-tracking branch 'upstream/master'
wes337 792867e
Merge remote-tracking branch 'upstream/master'
wes337 cb60398
[@mantine/core] Multiselect: fix line heights
wes337 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same way the line height is calculated in the Input styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will in work correctly is MultiSelect has multiple lines? It happens when there are a lot of items selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me:
Chrome:
Edge:
The items are not actually part of the input element. But the placeholder text is.