Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Group: use css selectors to style children #2162

Merged
merged 1 commit into from Sep 17, 2022

Conversation

drj17
Copy link
Contributor

@drj17 drj17 commented Aug 18, 2022

Replaces the logic in <Group /> that passes className as prop with a direct child selector. This removes the requirement for Group children to accept className as a prop.

@drj17 drj17 changed the base branch from master to dev August 19, 2022 17:51
@drj17 drj17 changed the base branch from dev to master August 19, 2022 17:51
@drj17 drj17 force-pushed the use-css-selectors-for-group-children branch from 854bf74 to 8f010a1 Compare August 29, 2022 16:31
@drj17 drj17 changed the base branch from master to dev August 29, 2022 16:31
@rtivital rtivital merged commit c4f6c7b into mantinedev:dev Sep 17, 2022
@rtivital
Copy link
Member

Thanks!

@danielemesh
Copy link

@drj17 this makes it impossible to override a Group's direct child flex-grow rule without using !important or another css selector that is more "powerful" than > * 😢
and IMHO it's a breaking change that needs to be documented...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants