ActionIcon: Fix mismatch between demo apparent code and real code #2189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the screenshots and the videos in the discord thread: https://discord.com/channels/854810300876062770/1010668931842855064
This PR is more of a "Expose the problem to the maintainers" PR than anything, even though it does fix the mismatch
The demo real code was changing both the ActionIcon's size and the embedded Icon's size.
While this seems to be desirable, it was not reflected in the apparent demo code.
There are two way to "fix" this. One simple way, and one difficult way
This PR takes the first option, as it is the most straightforward, but I believe the second option might be better. It would require extensive string manipulation though to change the template code and I want to leave that to the maintainer discretion
Before:
After: