New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@mantine/core] Indicator: count support #2237
Conversation
Hi @AmelloAster, thanks for a PR, please change |
ok |
I've finished changing |
@AmelloAster can you please resolve conflicts? |
OK |
Thanks! |
This pr I did two things in total
The first one.
Enrich the functionality of Indicator
processing
animationshowZero
controldisabled
=>isShow
For the fifth point, I think the name
disabled
will bring misunderstanding,disabled
usually means the component isdisabled
, but it is still displayed, while this time is to control whether the component is displayed or not, so I thinkisShow
is more appropriateThe second piece: enrich is function
I encapsulated an is function file, which contains many basic type determination functions, and I think there will be related needs in the subsequent development
Indicator-related docs and demos have been added, and unit tests for the is function have been passed.