Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Indicator: count support #2237

Merged
merged 8 commits into from Sep 9, 2022

Conversation

AmelloAster
Copy link
Contributor

@AmelloAster AmelloAster commented Aug 26, 2022

This pr I did two things in total
The first one.
Enrich the functionality of Indicator

  1. Digital overflow display
  2. Digital animation
  3. processing animation
  4. showZero control
  5. disabled => isShow
    For the fifth point, I think the name disabled will bring misunderstanding, disabled usually means the component is disabled, but it is still displayed, while this time is to control whether the component is displayed or not, so I think isShow is more appropriate
    The second piece: enrich is function
    I encapsulated an is function file, which contains many basic type determination functions, and I think there will be related needs in the subsequent development

Indicator-related docs and demos have been added, and unit tests for the is function have been passed.
image
image

@rtivital
Copy link
Member

Hi @AmelloAster, thanks for a PR, please change isShow to disabled back to merge it – it is a breaking change and we cannot introduce it in minor release.

@AmelloAster
Copy link
Contributor Author

AmelloAster commented Aug 26, 2022

Hi @AmelloAster, thanks for a PR, please change isShow to disabled back to merge it – it is a breaking change and we cannot introduce it in minor release.

ok

@AmelloAster
Copy link
Contributor Author

Hi @AmelloAster, thanks for a PR, please change isShow to disabled back to merge it – it is a breaking change and we cannot introduce it in minor release.

I've finished changing

@rtivital
Copy link
Member

rtivital commented Sep 8, 2022

@AmelloAster can you please resolve conflicts?

@AmelloAster
Copy link
Contributor Author

@AmelloAster can you please resolve conflicts?

OK

@rtivital rtivital merged commit a8c45f8 into mantinedev:dev Sep 9, 2022
@rtivital
Copy link
Member

rtivital commented Sep 9, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants