[@mantine/core] Button: Button is disabled when inside fieldset disabled #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2022 18:19
rtivital
reviewed
Sep 14, 2022
| @@ -135,6 +135,15 @@ export default createStyles( | |||
|
|
|||
| '&:active': theme.activeStyles, | |||
|
|
|||
| '&:disabled': { | |||
There was a problem hiding this comment.
Should be &:disabled, &[data-disabled] to avoid styles duplication
There was a problem hiding this comment.
@rtivital sure I will add this to ActionIcon too.
Should I be adding this as a new style (as in this screenshot) or simply updating the existing style (the one marked 2 in screenshot):
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2428 using adding a disabled style to button, as suggested by @UgurKacak.
I added simple storybook story, wrapping the states example in a fieldset disabled, all buttons should be disabled.
I have added a basic test as well, please provide feedback if you'd like to see more details on top.