[docs] Text inherit - to have consistency between example and code example #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and code example
rtivital
reviewed
Sep 26, 2022
| @@ -5,7 +5,13 @@ const code = ` | |||
| import { Text, Title } from '@mantine/core'; | |||
|
|
|||
| function Demo() { | |||
| return <Title order={3}>Highlight <Text color="blue" inherit component="span">something</Text>in title</Title>; | |||
| return <Title order={3}> | |||
There was a problem hiding this comment.
It is formatted incorrectly, should be <Title order={3}>Title in which you want to<Text color="blue" inherit component="span">highlight</Text>something</Title>
There was a problem hiding this comment.
let me update it
|
Thanks! |
1 task
This was referenced Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using mantine for my project and currently heavily reading docs.
Found one example that got me confused and thought to have it fixed by having consistency between the example and the code example, so users can just copy and paste to their code base and start modifying.
It is not a big deal but hopes it can make the documentation even better