Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse click for closing modal #2611

Closed
wants to merge 1 commit into from

Conversation

MoreBlood
Copy link

Modal should not close on right mouse click, on 4/5 buttons and so on

Modal should not close on right mouse click, on 4/5 buttons and so on
@rtivital
Copy link
Member

rtivital commented Oct 3, 2022

This will cause some components dropdowns to close modal, for example, MultiSelect dropdown.

@MoreBlood
Copy link
Author

@rtivital Honestly, I don’t really understand how this is connected, can you give an example?
Now the name of the prop is misleading that click should be used instead of pressing any mouse button

@rtivital
Copy link
Member

rtivital commented Oct 3, 2022

When MultiSelect dropdown is rendered within portal, all clicks are registered as outside (because its actually outside). But this is unwanted behavior. onMouseDown event is used to solve that issue – you can view Select/MultiSelect code to learn how it is managed.

@rtivital
Copy link
Member

Fixed by #2669

@rtivital rtivital closed this Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants