[@mantine/hooks] use-timout: Add parameters for callback function #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtivital
requested changes
Oct 17, 2022
| @@ -1,16 +1,16 @@ | |||
| import { useRef, useEffect } from 'react'; | |||
|
|
|||
| export function useTimeout( | |||
| fn: () => void, | |||
There was a problem hiding this comment.
Why fn was renamed to callback?
There was a problem hiding this comment.
It was called callback in docs so I thought I change it to be consistant. callback seemed more descriptive than fn to me. Feel free to comment/change if you'd like to see it reversed.
| @@ -1,16 +1,16 @@ | |||
| import { useRef, useEffect } from 'react'; | |||
|
|
|||
| export function useTimeout( | |||
| fn: () => void, | |||
| callback: (callbackParams?: any) => void, | |||
There was a problem hiding this comment.
What if you want to pass more than one argument? Change type to allow any amount of arguments.
There was a problem hiding this comment.
Pushed changes based on your feedback.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue discussed here - https://discord.com/channels/854810300876062770/1029643292431892491/1029643292431892491
As of now, setTimeout callback function is called without any parameters. I found it to be useful when these parameters can be pased from start() function.