Added <span> tag around {children} in ListItem.tsx #2857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2146 makes a pull request that removes the
<span>
tag around the{children}
inListItem.tsx
This causes an overflow to happen in theListItem
, as represented in the image below. In this pull request, I re-added the<span>
tags.Before (from MantineUI, it overflows in to 2 lines):
After (my own personal project, it stays on one line):