Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update yarn cache in github action #3191

Merged
merged 1 commit into from Dec 17, 2022
Merged

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Dec 15, 2022

  • Currently, the yarn cache in the pull_request always misses. The total time to install dependencies take ~2 minutes.

    Screen Shot 2022-12-15 at 01 42 44
  • This PR fixes this issue by using the latest setup-node@v3.

  • With the new cache, it takes ~30 seconds to download the cache, and ~1 minute 10 seconds to install the dependencies. So in total it saves 20 seconds. It's not a huge improvement because the cache size is very large and it takes a while to download.

  • Also there are no more deprecated set-output / save-state command warnings.

  • Please note that the cache will only start to work on the second run. So on this PR, the installation time will remain the same. But here is a screenshot of subsequent runs:

    Screen Shot 2022-12-15 at 01 40 46

@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants