Introduce --no-detect-globals

lib/args.js

@@ -26,7 +26,8 @@ var defaults = {
   yields: '0',
   colors: null,
   'async-polling': true,
-  'request-interception': true
+  'request-interception': true,
+  'detect-globals': true
 };
 
 function args(argv) {
@@ -39,7 +40,7 @@ function args(argv) {
     boolean: ['help', 'version', 'watch', 'cover', 'node', 'wd', 'debug',
       'invert', 'recursive', 'colors', 'ignore-ssl-errors', 'browser-field',
       'commondir', 'allow-chrome-as-root', 'async-polling', 'dumpio',
-      'request-interception'],
+      'request-interception', 'detect-globals'],
     alias: {
       help: 'h',
       version: 'v',

lib/mochify.js

@@ -128,6 +128,8 @@ module.exports = function (_, opts) {
     brOpts.commondir = false;
     brOpts.detectGlobals = false;
     brOpts.insertGlobalVars = ['__dirname', '__filename'];
+  } else {
+    brOpts.detectGlobals = opts['detect-globals'];
   }
   brOpts.extensions = opts.extension;
   brOpts.browserField = opts['browser-field'];

package.json

@@ -66,7 +66,7 @@
     "url": "https://github.com/mantoni/mochify.js.git"
   },
   "dependencies": {
-    "brout": "^1.1.0",
+    "brout": "^1.3.0",
     "browserify": "^16.2.3",
     "consolify": "^2.1.0",
     "coverify": "^1.4.1",

test/args-test.js

@@ -31,6 +31,7 @@ describe('args', function () {
     assert.equal(opts['browser-field'], true);
     assert.equal(opts.commondir, true);
     assert.equal(opts['request-interception'], true);
+    assert.equal(opts['detect-globals'], true);
   });
 
   it('parses --reporter', function () {
@@ -330,6 +331,18 @@ describe('args', function () {
     assert.equal(opts['request-interception'], false);
   });
 
+  it('parses --detect-globals', function () {
+    var opts = args(['--detect-globals']);
+
+    assert(opts['detect-globals']);
+  });
+
+  it('parses --no-detect-globals', function () {
+    var opts = args(['--no-detect-globals']);
+
+    assert.equal(opts['detect-globals'], false);
+  });
+
   it('fails with invert but no grep option', function (done) {
     run('passes', ['--invert'], function (code, stdout) {
       assert.equal(code, 1);

test/chromium-test.js

@@ -463,6 +463,24 @@ describe('chromium', function () {
       });
   });
 
+  it('detects globals by default', function (done) {
+    run('detect-globals', ['-R', 'tap'],
+      function (code, stdout, stderr) {
+        assert.equal(stderr, 'object\n');
+        assert.equal(code, 0);
+        done();
+      });
+  });
+
+  it('allows to turn off global detection', function (done) {
+    run('detect-globals', ['--no-detect-globals'],
+      function (code, stdout, stderr) {
+        assert.equal(stderr, 'undefined\n');
+        assert.equal(code, 0);
+        done();
+      });
+  });
+
   context('https-server with a port value given', function () {
     var server;
     var port;

test/fixture/detect-globals/test/global.js

@@ -0,0 +1,10 @@
+/*global describe, it*/
+'use strict';
+
+describe('global', function () {
+
+  it('prints typeof global', function () {
+    console.error(typeof global);
+  });
+
+});