Upgrade to Mocaccino 5, use Mocha 8 and Puppeteer 9 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
May 24, 2021
| @@ -86,6 +85,7 @@ | |||
| "devDependencies": { | |||
| "@studio/changes": "^2.0.1", | |||
| "eslint": "^7.13.0", | |||
| "mocha": "^8.4.0", | |||
There was a problem hiding this comment.
It occured to me Mocha might just be a dev dependency here (as the tests should consume the Mocha used by mocaccino). Correct me if I'm wrong.
|
We could also include Browserify 17 in here while we're updating things. Changeset seems unproblematic https://github.com/browserify/browserify/releases/tag/v17.0.0 EDIT: seems some tests are failing when using Browserify 17, so we might need to look into that upgrade on its own if we want it. |
|
Awesome! Thank you 💯 for getting this accross the finish line. 🙏 🥇 I've already tested this in a large project and it works like a dream. 📦 Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213
Most of the changes in this PR are related to change in TAP output in Mocha 8 discussed here: mantoni/mocaccino.js#35 (comment)
The other issue we run into here is that the rollupified Mocha 8 browser bundle now prints a whole lot of deprecation warnings like:
When I inspect a bundle in my browser the warning points here: https://github.com/mochajs/mocha/blob/34643e4c0821aeb8d6977c1942bc106c9363789a/browser-entry.js#L219 (or rather there plus some Rollup code around it).
For now I'm not entirely sure we could fix this in any other way than just swallowing these warnings?