Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move __toBinary() to build rather than src, replace rollup/ts with esbuild #30

Merged
merged 4 commits into from
Jul 2, 2021

Conversation

manzt
Copy link
Owner

@manzt manzt commented Jun 28, 2021

No description provided.

@kylebarron
Copy link

How much faster is esbuild for you?

@manzt
Copy link
Owner Author

manzt commented Jun 28, 2021

I'd like to move to esbuild all together because it's noticeably faster, and the custom base64 plugin emulates the behavior/is copied from esbuild's binary loader already. The tests for numcodecs.js require building from src before running, and with esbuild it's ms.

The main issue is that chunks aren't desirable in the esbuild-only build (evanw/esbuild#492) currently. I think if/when manualChunks in esbuild, I'll be able to remove rollup and all rollup plugins. This PR sets the foundation for that future, since all the esbuild-like behavior is now a part of the hybrid rollup build and can easily be swapped out.

@manzt manzt merged commit 9ad7d27 into main Jul 2, 2021
@manzt manzt deleted the new-base64 branch July 2, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants