Skip to content

fire map mouse events during scroll zooming #10171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2020
Merged

fire map mouse events during scroll zooming #10171

merged 2 commits into from
Dec 9, 2020

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Dec 9, 2020

fix #10155

Moving BlockableMapEventHandler above ScrollZoomHandler prevents it from being blocked by that handler.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • [n/a] document any changes to public APIs
  • [n/a] post benchmark scores
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix firing map mouse events during scroll zoom.</changelog>

Sorry, something went wrong.

fix #10155

Moving BlockableMapEventHandler above ScrollZoomHandler prevents it from
being blocked by that handler.
@ansis ansis added the bug 🐞 label Dec 9, 2020
@ansis ansis requested a review from ryanhamley December 9, 2020 20:44
Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No mouse events on layers are fired during scrolling/zooming
4 participants