-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: send geolocation as adapter #10400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As mentioned by @mourner in the other PR, CI will need to be addressed prior to review. The failed tests are build and unit-test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still waiting for green CI builds (currently some tests are failing).
Do we have any updates about this PR? |
a0d196a
to
40caf81
Compare
Sorry for the delay @behnammodi — we're investigating why the CI doesn't run all the jobs properly, even though you have rebased everything on |
@mourner No problem, thanks a lot |
I didn't know how to resolve the CI being stuck, so ended up rebasing this and making a new PR with your changes here: #11614 |
Go ahead |
geolocation
behavior.So now we have:
I'll say welcome to your awesome feedback :)
Continue this PR #10232