Skip to content

Fix rendering bug in formatted images using case expressions #10553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

ryanhamley
Copy link
Contributor

@ryanhamley ryanhamley commented Apr 9, 2021

Launch Checklist

Fixes #10552

Before
Screen Shot 2021-04-09 at 3 16 45 PM
After
Screen Shot 2021-04-09 at 3 17 14 PM

  • write tests for all new functionality
    TODO
  • manually test the debug page
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Allow formatted images in text to use be displayed conditionally</changelog>

Sorry, something went wrong.

Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks!

@ryanhamley ryanhamley marked this pull request as ready for review April 12, 2021 16:07
@ryanhamley ryanhamley merged commit c89209c into main Apr 12, 2021
@ryanhamley ryanhamley deleted the fallback-images-in-text branch April 12, 2021 16:07
@karimnaaji karimnaaji added this to the v2.3 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants