Fix undefined type error when removing line-gradient paint property #10557
+66
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Render test is added to cover triple buffering line programs in Metal. Solid color and gradient line program uses the same uniform buffer: this test covers the case when, for one layer, line program (with larger uniform buffer requirements) is used after line_gradient. In gl-js this triggered `Uncaught TypeError: Cannot read property 'expression' of undefined` in https://github.com/mapbox/mapbox-gl-js/blob/d66ff288e7ab2e917e9e676bee942dd6a46171e7/src/style/style_layer/line_style_layer.js#L64.
ghost
mentioned this pull request
mourner
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render test is added to cover triple buffering in gl-native's Metal backend. There, solid color and gradient line program reuse the same uniform buffer: this test specifically covers the case when, for one layer, line program (with larger uniform buffer requirements) is used after line_gradient program (when line-gradient paint property gets disabled).
In gl-js, this triggered
Uncaught TypeError: Cannot read property 'expression' of undefinedinmapbox-gl-js/src/style/style_layer/line_style_layer.js
Line 64 in d66ff28
Fix for it is included here.