Reuse one renderbuffer for all draping. #10611
Merged
+20
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every framebuffer currently instantiate own renderbuffer of (1024 x 1024 x depth24_stencil8 =) 4MB. Renderbuffers are lazily instantiated, when stencil is needed for draping and it is needed seldomly as proxy tiles raster cover most of stencil needs. E.g. when zooming out, 3 out of 50 render cache / pool framebuffers may need stencilling. This memory was accumulated and not released with potential growth to up to (50 render cache tiles + 5 pool tiles) * 4MB = 220MB of renderbuffers. The PR is replacing this with one render buffer attached to all 55 framebuffers.
astojilj
added
performance ⚡
karimnaaji
approved these changes
Apr 29, 2021
src/terrain/terrain.js
Outdated
| } | ||
|
|
||
| _initFBOPool() { | ||
| while (this.pool.length < Math.min(FBO_POOL_SIZE, this.proxyCoords.length)) { | ||
| this.pool.push(this._createFBO()); | ||
| this.pool.push(this._createFBO(this.pool.length > 0 ? this.pool[0].fb.depthAttachment.current : null)); |
There was a problem hiding this comment.
Pushed a small simplification to make it more explicit that we're sharing the depth stencil between these framebuffers with this change in e9768c5 (with this.pool.length > 0 ? this.pool[0].fb.depthAttachment.current : null) here and this.pool[index % FBO_POOL_SIZE].fb.depthAttachment.current line 1001, I didn't find it immediately obvious where the depth attachment was coming from at framebuffer creation time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every framebuffer currently instantiate own renderbuffer of (1024 x 1024 x depth24_stencil8 =) 4MB. Renderbuffers are lazily instantiated, when stencil is needed for draping and it is rarely needed as proxy tiles raster approach covers most of stenciling needs. E.g. when zooming out, 3 out of 50 render cache / pool framebuffers may need stenciling. This memory was accumulated and not released, with potential to grow up to (50 render cache tiles + 5 pool tiles) * 4MB = 220MB of renderbuffers. The PR is replacing this with one render buffer attached to all 55 framebuffers.
Verified on macos, iOS and Android (Nexus 5).
Spector capture information before 131MB (left) - after 11MB (right). Renderbuffer memory on screenshot includes depth FBO's renderbuffer (screen size) + 4MB for draping.
