Upgrade to TinySDF v2 with a fix to CJK performance #11047
Merged
+43
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
reviewed
Sep 22, 2021
Comment on lines
+219
to
+220
| tinySDF = entry.tinySDF = new GlyphManager.TinySDF({fontFamily, fontWeight, fontSize, buffer, radius}); | ||
| tinySDF.fontWeight = fontWeight; |
There was a problem hiding this comment.
Just curious, why do we need to set tinySDF.fontWeight when fontWeight is passed into the constructor?
There was a problem hiding this comment.
@ryanhamley it was never a part of public TinySDF API, it just happened to be exposed there but is no longer the case with v2.
This was referenced Sep 24, 2021
mourner
added a commit
that referenced
this pull request
Sep 29, 2021
* upgrade to TinySDF v2 * update tiny-sdf to v2.0.2 to address a perf issue
mourner
added a commit
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades TinySDF to v2. In particular, the new version:
@ChrisLoer please review to make sure this doesn't cause any regressions on our CJK-heavy styles.
Launch Checklist
mapbox-gl-jschangelog:<changelog>Fixed an issue with slow tile loading performance on maps with CJK glyphs on certain Chrome/GPU combinations.</changelog>