Fix gl-js-team/issues/309 #11346
Merged
Fix gl-js-team/issues/309 #11346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since stencil may be shared between different tiles we need to now ensure it is cleared when recycled
ryanhamley
approved these changes
Dec 15, 2021
|
I manually confirmed that this fixes the flickering issue. Nice work |
|
When the data volume is more than one million, the vector layers will appear crazy flickering when they are stacked together. After testing, this problem will not occur before 2.6.1, but will occur after this version. version: mapbox-gl@2.11.1 2.11.1.mp4version: mapbox-gl@2.6.1 2.6.1.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the stencil renderbuffer may be shared between different tiles we need to ensure that it is cleared when recycled. Otherwise stale data left in that buffer may interfere with the new tiles sharing that same buffer, resulting in flickering in complex source overlap situations. The flicker is very difficult to trigger in a render tests environment, as it require toggling terrain on and off and zooming fast in and out.
https://github.com/mapbox/gl-js-team/issues/309
<changelog>Fix a rare terrain flickering issue when using terrain with multiple vector data sources</changelog>