Fix redundant title in Map Feedback attribution #11360
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avpeery
added
bug 🐞
skip changelog
avpeery
removed
the
skip changelog
ryanhamley
approved these changes
Dec 23, 2021
| @@ -98,6 +98,7 @@ class AttributionControl { | |||
| _setElementTitle(element: HTMLElement, title: string) { | |||
| const str = this._map._getUIString(`AttributionControl.${title}`); | |||
| element.setAttribute('aria-label', str); | |||
| if (element.hasAttribute('title')) element.removeAttribute('title'); | |||
There was a problem hiding this comment.
nit: the if statement isn't strictly necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11324. PR #11064 removed adding a title attribute to Map Feedback (which was overwriting the previous title attribute "improve this map" that comes from the vector tile source). This quick fix removes the title attribute for Map Feedback as aria-label is being used instead.
Launch Checklist
Improve this Mapattribution element