Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include map aria-label in locale #11549

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Include map aria-label in locale #11549

merged 2 commits into from
Mar 31, 2022

Conversation

andrewharvey
Copy link
Collaborator

@andrewharvey andrewharvey commented Feb 24, 2022

Launch Checklist

  • briefly describe the changes in this PR
    Include map aria-label in locale
  • include before/after visuals or gifs if this PR includes visual changes
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
    Yes and I added a new debug page because I couldn't find it in an existing one.
  • tagged @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes
  • tagged @mapbox/gl-native if this PR includes shader changes or needs a native port
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
    feature?
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog:
    <changelog>AddMap.Titleproperty to locale options to localise the maparia-label.</changelog>

Sorry, something went wrong.

@avpeery avpeery added skip changelog Used for PRs that do not need a changelog entry and removed skip changelog Used for PRs that do not need a changelog entry labels Mar 31, 2022
@asheemmamoowala asheemmamoowala merged commit 9fff531 into main Mar 31, 2022
@asheemmamoowala asheemmamoowala deleted the locale-map branch March 31, 2022 16:45
@asheemmamoowala
Copy link
Contributor

Thanks @andrewharvey!!

ansis pushed a commit that referenced this pull request Apr 11, 2022
Exposes Map aria-label in locale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants