fix map center calculation in ScaleControl #11657
Merged
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Mar 31, 2022
|
Thanks @stepankuzmin! I think a unit test would be helpful otherwise looks good to me |
SnailBones
pushed a commit
that referenced
this pull request
Apr 5, 2022
SnailBones
added a commit
that referenced
this pull request
Apr 5, 2022
* Removing -beta.1 suffix from style specs and changelogs * Adding new item to changelog CHERRY PICK ME TO MAIN * fix map center calculation in ScaleControl (#11657) * refactor CustomSource (#11649) * use empty image if the implementation returns nothing * Removing globe from scale test to get CI to pass * Add github actions workflow to check changelog requirements in PR (#11651) * implement github actions with a javascript actions to check pull requests for changelogs or skip changelog labels * Add `synchronize` to check-changelog github action types (#11653) * add synchronize to types to trigger with new commit pushes Co-authored-by: Stepan Kuzmin <stepan.kuzmin@mapbox.com> Co-authored-by: Anna Peery <42715836+avpeery@users.noreply.github.com>
ansis
pushed a commit
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scale control was always using the left-hand side of the map to calculate the scale. In some cases, e.g., when using the Equal Earth projection, the scale couldn't calculate correctly.
Launch Checklist
mapbox-gl-jschangelog:<changelog>fix map center calculation in ScaleControl</changelog>