Optimize tile calculations for globe #12050
Merged
+57
−83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling globe view, I noticed that
aabbForTileOnGlobe
takes ~5% of CPU time, and makes quite a lot of allocations for a hot path function that's called many times per frame. This PR eliminates most redundant allocations, bringing it below 1% in the profiler. See the two self-contained commits:globeMatrix
and scale things inline when calculating bounding volume corners.LngLat
corners of a bounding box are encapsulated inLngLatBounds
which we designated for such cases.Launch Checklist
@mapbox/gl-native
if this PR includes shader changes or needs a native portmapbox-gl-js
changelog:<changelog>Improve rendering performance on globe view</changelog>