Fix GeolocateControl in Safari #12080
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why CodeBuild failed on the second commit, might be a fluke. |
karimnaaji
pushed a commit
that referenced
this pull request
Jul 14, 2022
* fix GeolocateControl in Safari * update geolocate unit test to cover the fix
karimnaaji
added a commit
that referenced
this pull request
Jul 14, 2022
* Fallback to hardcoded units in browsers without `NumberFormat` support in `ScaleControl` (#12068) Add a workaround in ScaleControl to support localization in browsers without NumberFormat support Co-authored-by: Ansis Brammanis <ansis@mapbox.com> * Fix GeolocateControl in Safari (#12080) * fix GeolocateControl in Safari * update geolocate unit test to cover the fix Co-authored-by: Stepan Kuzmin <stepan.kuzmin@mapbox.com> Co-authored-by: Ansis Brammanis <ansis@mapbox.com> Co-authored-by: Volodymyr Agafonkin <agafonkin@gmail.com>
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12074. Turns out #11614 broke
GeolocateControlin Safari, because the latter doesn't support the location permissions API, and the fallback route wasn't checked / caught by tests. I updated the unit test so that it fails without the fix, not sure if there's a better way to cover this...Launch Checklist
mapbox-gl-jschangelog:<changelog>Fix GeolocateControl not working in Safari</changelog>