Allowing two-finger pitch with cooperative gestures in fullscreen #12165
+111
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12058, which fixed cooperative gestures dragging behavior and warning message incorrectly appearing in fullscreen on mobile (#11635). A small oversight was that the cooperative gestures still applied to touch pitch, making them require 3 instead of 2 fingers, which causes two finger interactions to instead pan the map. This PR makes fullscreen behavior consistent with maps without cooperative gestures.
Also adds previously missing tests for touch pitch.
Here I test a two-finger drag on Android:
Before fix:
pitch-broken.webm
After fix:
pitch-fixed.webm
Launch Checklist
mapbox-gl-js
changelog:<changelog>Fix incorrectly requiring three finger drags to change pitch with cooperative gestures while in fullscreen.</changelog>