This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Build fixes for gcc 10 and 11 #16608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this gcc 10.2.0 complains about the loops condition never to be
true with the following error:
src/mbgl/style/expression/compound_expression.cpp: In instantiation of ‘mbgl::style::expression::EvaluationResult mbgl::style::expression::detail::Signature<R(const mbgl::style::expression::EvaluationContext&, Params ...)>::applyImpl(const mbgl::style::expression::EvaluationContext&, const Args&, std::index_sequence<I ...>) const [with long unsigned int ...I = {}; R = mbgl::style::expression::Result<bool>; Params = {}; mbgl::style::expression::detail::SignatureBase::Args = std::vector<std::unique_ptr<mbgl::style::expression::Expression> >; std::index_sequence<I ...> = std::integer_sequence<long unsigned int>]’:
src/mbgl/style/expression/compound_expression.cpp:154:25: required from ‘mbgl::style::expression::EvaluationResult mbgl::style::expression::detail::Signature<R(const mbgl::style::expression::EvaluationContext&, Params ...)>::apply(const mbgl::style::expression::EvaluationContext&, const Args&) const [with R = mbgl::style::expression::Result<bool>; Params = {}; mbgl::style::expression::detail::SignatureBase::Args = std::vector<std::unique_ptr<mbgl::style::expression::Expression> >]’
src/mbgl/style/expression/compound_expression.cpp:153:22: required from here
src/mbgl/style/expression/compound_expression.cpp:161:35: error: comparison of unsigned expression in ‘< 0’ is always false [-Werror=type-limits]
161 | for (std::size_t i = 0; i < sizeof...(Params); ++i) {
| ~~^~~~~~~~~~~~~~~~~~~
This is needed for gcc 11.1.0
Fixes the compilation with gcc 11.1.0
This fixes the following error encountered with gcc 11.1.0: /usr/bin/ld: ../libmbgl-core.a(thread.cpp.o): undefined reference to symbol 'pthread_setname_np@@GLIBC_2.12' /usr/bin/ld: /usr/lib/libpthread.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit describes the concrete problem it fixes.