Multiple Time Windows per Location #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-j-h
force-pushed
the
multiple-time-windows
branch
from
0ef3607
to
26a840c
Compare
|
Oh, thank you! |
|
@Herteby, any plans on finishing this? |
|
Sorry, I no longer work at the company that was using this.
2018-07-27 15:18 GMT+02:00 Ivo Sabev <notifications@github.com>:
… @Herteby <https://github.com/Herteby>, any plans on finishing this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGLLvUQ0SfDAyvaOGS9wkaN7oXkFU9mTks5uKxMWgaJpZM4OLWI3>
.
|
david-paulus-saad
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8.
@Herteby here's a first pass at multiple time windows per day - the api for time windows changes from an array of intervals per location to an array of multiple intervals per location. Intervals need to be sorted and not overlap - we could think of relaxing these constraints a bit but it would require a bit more code in the implementation.
Could you play with it and report back how it works for you? Maybe also test some edge cases and unexpected inputs. If everything works out nicely I'm more than happy to merge this into master and cut a new release.
cc @karenzshea