Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node 17 support #612

Merged
merged 1 commit into from Oct 20, 2021
Merged

Conversation

ewanharris
Copy link
Contributor

Updates abi_crosswalk to include newer versions of node, including 17

@springmeyer
Copy link
Contributor

Thanks @ewanharris, will do a new release with this soon

@ewanharris
Copy link
Contributor Author

@springmeyer, I hit an issue with 17.0.0 where it was missing headers and causing the build to fail. I think 17.0.1 is potentially being released today with the fix (nodejs/node/pull/40535).

Once that's released I'll add 17.0.1 to this PR so that it can be used

@springmeyer
Copy link
Contributor

Once that's released I'll add 17.0.1 to this PR so that it can be used

Sounds good. Although the way the code is written internally in node-pre-gyp, it should not need 17.0.1 explicitly declared in order to function properly. It only needs at least one major version declared. I realize this is not obvious (you'd think the explicit nature of the crosswalk means that the minor and patch versions are needed, but that was avoided after f091f23#diff-731dda4952e8957a5d9387cd5ed656a10a7a6fd6e22b1ab3ef12502a9917e03d)

@ewanharris
Copy link
Contributor Author

Oh that's neat, I didn't realise that! I guess this is good to merge then!

@springmeyer springmeyer merged commit 81bcaa6 into mapbox:master Oct 20, 2021
hyj1991 pushed a commit to X-Profiler/node-pre-gyp that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants